[
https://issues.apache.org/jira/browse/FLINK-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745485#comment-15745485
]
ASF GitHub Bot commented on FLINK-5325:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2992#discussion_r92199074
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/CloseableRegistryImpl.java ---
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.core.fs;
+
+import org.apache.flink.util.AbstractCloseableRegistry;
+
+import java.io.Closeable;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * This class allows to register instances of {@link Closeable}, which are
all closed if this registry is closed.
+ * <p>
+ * Registering to an already closed registry will throw an exception and
close the provided {@link Closeable}
+ * <p>
+ * All methods in this class are thread-safe.
+ */
+public class CloseableRegistryImpl extends
AbstractCloseableRegistry<Closeable, Object> implements CloseableRegistry {
--- End diff --
I also totally agree that it should implement ``CloseableRegistry ``.
However, this it can not trivially implement the interface without making
``CloseableRegistry `` generic in ``<C extends Closeable>``. This in turn
would lead to some nasty naming like ``CloseableRegistry<Closeable>``. Maybe it
is just a naming problem after all, just yet lacking the right idea on those
names :-)
> Introduce interface for CloseableRegistry to separate user from system-facing
> functionality
> -------------------------------------------------------------------------------------------
>
> Key: FLINK-5325
> URL: https://issues.apache.org/jira/browse/FLINK-5325
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> Currently, the API of {{CloseableRegistry}} exposes the {{close}} method to
> all client code. We should separate the API into a user-facing interface
> (allowing only for un/registration of {{Closeable}} and a system-facing part
> that also exposes the {{close}} method. This prevents users from accidentally
> calling {{close}}, thus closing resources that other callers registered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
