[
https://issues.apache.org/jira/browse/FLINK-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15745414#comment-15745414
]
ASF GitHub Bot commented on FLINK-5325:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2992
Changes look good to me. But I think that @zentol is right that
`AbstractCloseableRegistry` should probably implement the `CloseableRegistry`
interface from an OOP point of view.
> Introduce interface for CloseableRegistry to separate user from system-facing
> functionality
> -------------------------------------------------------------------------------------------
>
> Key: FLINK-5325
> URL: https://issues.apache.org/jira/browse/FLINK-5325
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> Currently, the API of {{CloseableRegistry}} exposes the {{close}} method to
> all client code. We should separate the API into a user-facing interface
> (allowing only for un/registration of {{Closeable}} and a system-facing part
> that also exposes the {{close}} method. This prevents users from accidentally
> calling {{close}}, thus closing resources that other callers registered.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
