Zakelly opened a new pull request, #26977:
URL: https://github.com/apache/flink/pull/26977
## What is the purpose of the change
In [LINK-32086, we delete the orphan directories created by file-merging
manager. The orphan check depends on the checkpoint notifications. So we should
tolerate RPC messages lost, but current implementation using reference counting
which does not verify the message completeness using checkpoint id. This PR
fixes this by record the checkpoint id that reference the directory to prevent
messages mismatch.
## Brief change log
- Change `DirectoryHandleWithReferenceTrack`, using checkpoint id
accounting instead of just single reference count
## Verifying this change
This change added tests in `testManagedDirCleanup()`, simulating the RPC
loss.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
