Zakelly commented on code in PR #26977:
URL: https://github.com/apache/flink/pull/26977#discussion_r2338945389
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -955,13 +955,13 @@ boolean isCheckpointDiscard(long checkpointId) {
protected static class DirectoryHandleWithReferenceTrack {
private final DirectoryStreamStateHandle directoryHandle;
- // reference count by ongoing checkpoint
- private final AtomicLong ongoingRefCount;
+ // reference by ongoing checkpoint
+ private final Set<Long> refCheckpointIds;
private boolean tracking;
DirectoryHandleWithReferenceTrack(DirectoryStreamStateHandle
directoryHandle, boolean own) {
this.directoryHandle = directoryHandle;
- this.ongoingRefCount = new AtomicLong(0);
+ this.refCheckpointIds = new HashSet<>();
Review Comment:
Well we don't need thread-safe here, since these notification are processed
in the mailbox thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
