davidradl commented on code in PR #26977:
URL: https://github.com/apache/flink/pull/26977#discussion_r2339210850
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -1001,6 +1001,7 @@ void handoverOwnershipWhenCheckpointComplete(long
checkpointId) {
checkpointId,
directoryHandle.getDirectory());
tracking = false;
+ refCheckpointIds.clear();
Review Comment:
I am curious - we come into a method with one checkpointId and we are
clearing the set in 2 places, could you explain why we need to do this and not
just remove the id we are called with; maybe add a comment with the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
