yuxiqian commented on code in PR #4101:
URL: https://github.com/apache/flink-cdc/pull/4101#discussion_r2342864754
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/reader/external/Fetcher.java:
##########
@@ -33,7 +34,7 @@
public interface Fetcher<T, Split> {
/** Add to task to fetch, this should call only when the reader is idle. */
- void submitTask(FetchTask<Split> fetchTask);
+ Future<?> submitTask(FetchTask<Split> fetchTask);
Review Comment:
It's a little suspicious to alter public API just for testing. What about
store the `Future<?>` as a private field in `IncrementalSourceScanFetcher`, and
expose it with a `@VisibleForTesting` method so we can test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
