loserwang1024 commented on code in PR #4101:
URL: https://github.com/apache/flink-cdc/pull/4101#discussion_r2343249489
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/reader/external/IncrementalSourceScanFetcher.java:
##########
@@ -86,18 +88,21 @@ public IncrementalSourceScanFetcher(FetchTask.Context
taskContext, int subtaskId
}
@Override
- public void submitTask(FetchTask<SourceSplitBase> fetchTask) {
+ public Future<?> submitTask(FetchTask<SourceSplitBase> fetchTask) {
+ CompletableFuture<Void> completableFuture = new CompletableFuture<>();
+
this.snapshotSplitReadTask = fetchTask;
this.currentSnapshotSplit = fetchTask.getSplit().asSnapshotSplit();
taskContext.configure(currentSnapshotSplit);
this.queue = taskContext.getQueue();
this.hasNextElement.set(true);
this.reachEnd.set(false);
- executorService.execute(
+ return executorService.submit(
() -> {
try {
snapshotSplitReadTask.execute(taskContext);
+ completableFuture.complete(null);
Review Comment:
remove this future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
