ruanhang1993 commented on code in PR #4101:
URL: https://github.com/apache/flink-cdc/pull/4101#discussion_r2343161251


##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/reader/BinlogSplitReader.java:
##########
@@ -148,8 +150,6 @@ public void submitSplit(MySqlSplit mySqlSplit) {
                                         currentBinlogSplit),
                                 t);
                         readException = t;
-                    } finally {
-                        stopBinlogReadTask();

Review Comment:
   This part is added from https://github.com/apache/flink-cdc/pull/2901 .
   
   Will deleting this method here cause that the snapshot only fails?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to