davidradl commented on code in PR #27042:
URL: https://github.com/apache/flink/pull/27042#discussion_r2401622623
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStResourceContainer.java:
##########
@@ -370,28 +330,31 @@ public int getWriteIoParallelism() {
* @throws Exception if any unexpected behaviors.
*/
public void prepareDirectories() throws Exception {
- if (remoteBasePath != null && remoteForStPath != null) {
- remotePathNewlyCreated = prepareDirectories(remoteBasePath,
remoteForStPath);
+ if (pathContainer.getRemoteBasePath() != null
+ && pathContainer.getRemoteForStPath() != null) {
+ remotePathNewlyCreated =
+ prepareDirectories(
+ pathContainer.getRemoteBasePath(),
pathContainer.getRemoteForStPath());
}
- if (localBasePath != null && localForStPath != null) {
- prepareDirectories(
- new Path(localBasePath.getPath()), new
Path(localForStPath.getPath()));
+ if (pathContainer.getLocalBasePath() != null &&
pathContainer.getLocalForStPath() != null) {
+ prepareDirectories(pathContainer.getLocalBasePath(),
pathContainer.getLocalForStPath());
}
- if (remoteForStPath != null && localForStPath != null) {
- if (cacheBasePath == null && localBasePath != null) {
- cacheBasePath = new Path(localBasePath.getPath(), "cache");
+ if (pathContainer.getRemoteForStPath() != null
+ && pathContainer.getLocalForStPath() != null) {
+ if (cacheBasePath == null && pathContainer.getLocalBasePath() !=
null) {
+ cacheBasePath = new
Path(pathContainer.getLocalBasePath().getPath(), "cache");
Review Comment:
I assume thr log is incorrect, `not` should be `now `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
