davidradl commented on code in PR #27042:
URL: https://github.com/apache/flink/pull/27042#discussion_r2401661084
##########
flink-state-backends/flink-statebackend-forst/src/test/java/org/apache/flink/state/forst/datatransfer/DataTransferStrategyTest.java:
##########
@@ -524,19 +531,76 @@ void testBuildingStrategyAsExpected() throws IOException {
CopyDataTransferStrategy.class);
testRestoreStrategyAsExpected(
- forStFlinkFileSystem, RecoveryClaimMode.CLAIM,
ReusableDataTransferStrategy.class);
+ forStFlinkFileSystem,
+ "/src-dir",
+ "/dst-dir",
+ RecoveryClaimMode.CLAIM,
+ ReusableDataTransferStrategy.class);
+
+ testRestoreStrategyAsExpected(
+ forStFlinkFileSystem,
+ "/src-dir",
+ "/dst-dir",
+ RecoveryClaimMode.NO_CLAIM,
+ CopyDataTransferStrategy.class);
+
+ testRestoreStrategyAsExpected(
+ forStFlinkFileSystem,
+ "/src-dir",
+ "/dst-dir",
+ RecoveryClaimMode.LEGACY,
+ ReusableDataTransferStrategy.class);
+
+ testRestoreStrategyAsExpected(
+ null,
+ "/src-dir",
+ "/dst-dir",
+ RecoveryClaimMode.CLAIM,
+ CopyDataTransferStrategy.class);
+
+ testRestoreStrategyAsExpected(
+ null,
+ "/src-dir",
+ "/dst-dir",
+ RecoveryClaimMode.NO_CLAIM,
+ CopyDataTransferStrategy.class);
+ // Restoring from the same directory indicates a failover scenario,
allowing us to reuse the
+ // files if we are in a disaggregated setup.
testRestoreStrategyAsExpected(
- forStFlinkFileSystem, RecoveryClaimMode.NO_CLAIM,
CopyDataTransferStrategy.class);
+ forStFlinkFileSystem,
+ "/same-dir",
+ "/same-dir",
+ RecoveryClaimMode.CLAIM,
+ ReusableDataTransferStrategy.class);
testRestoreStrategyAsExpected(
- forStFlinkFileSystem, RecoveryClaimMode.LEGACY,
ReusableDataTransferStrategy.class);
+ forStFlinkFileSystem,
+ "/same-dir",
+ "/same-dir",
+ RecoveryClaimMode.NO_CLAIM,
+ ReusableDataTransferStrategy.class);
testRestoreStrategyAsExpected(
- null, RecoveryClaimMode.CLAIM, CopyDataTransferStrategy.class);
+ forStFlinkFileSystem,
+ "/same-dir",
+ "/same-dir",
+ RecoveryClaimMode.LEGACY,
+ ReusableDataTransferStrategy.class);
testRestoreStrategyAsExpected(
- null, RecoveryClaimMode.NO_CLAIM,
CopyDataTransferStrategy.class);
+ null,
+ "/same-dir",
+ "/same-dir",
+ RecoveryClaimMode.CLAIM,
+ CopyDataTransferStrategy.class);
+
+ testRestoreStrategyAsExpected(
Review Comment:
parameterized test for all these permutations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
