davidradl commented on code in PR #27042:
URL: https://github.com/apache/flink/pull/27042#discussion_r2401648423
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/sync/ForStSyncKeyedStateBackend.java:
##########
@@ -488,18 +488,13 @@ public void dispose() {
columnFamilyOptions.forEach(IOUtils::closeQuietly);
LOG.info(
- "Closed ForSt State Backend. Cleaning up ForSt local
working directory {}, remote working directory {}.",
- optionsContainer.getLocalBasePath(),
- optionsContainer.getRemoteBasePath());
+ "Closed ForSt State Backend. Cleaning up ForSt: {}.",
+ optionsContainer.getPathContainer());
try {
optionsContainer.clearDirectories();
} catch (Exception ex) {
- LOG.warn(
- "Could not delete ForSt local working directory {},
remote working directory {}.",
- optionsContainer.getLocalBasePath(),
- optionsContainer.getRemoteBasePath(),
- ex);
+ LOG.warn("Could not delete ForSt: {}.",
optionsContainer.getPathContainer(), ex);
Review Comment:
nit: it seems we lose information here. I read the log entry text before
`Could not delete ForSt local working directory {}` to means it is only the
local directory that could not be deleted and we put out the remote directory
for information. It would be good to point to the actual folder that could not
be deleted in the new log message - rather than list all the folders and not
know which could not be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
