davidradl commented on code in PR #27294:
URL: https://github.com/apache/flink/pull/27294#discussion_r2580343601
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ProviderContext.java:
##########
@@ -41,4 +41,26 @@ public interface ProviderContext {
* in batch mode, or UIDs cannot be guaranteed to be unique.
*/
Optional<String> generateUid(String name);
Review Comment:
Is this name the same as the name in getName()? If the getName is different
and a label - maybe call that name label or displayName.
I suggest: Either:
- separating the 2 names ;one as an identifier, one as label - or equivalent
words. Labels could be duplicates ,but are not ideal, but having the
identifiers unique is the important part.
- use one name and have generateUid call getName() to obtain the name it
works with.
I prefer the first option , so you could have a namespaced identifier and a
human readable label. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
