twalthr commented on code in PR #27294:
URL: https://github.com/apache/flink/pull/27294#discussion_r2581153282
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ProviderContext.java:
##########
@@ -41,4 +41,26 @@ public interface ProviderContext {
* in batch mode, or UIDs cannot be guaranteed to be unique.
*/
Optional<String> generateUid(String name);
+
+ /**
+ * Returns the name provided by the framework to label the connector.
+ *
+ * <p>If multiple transformations are present, the implementer decides
which one is the
+ * connector. To distinguish between transformations, each transformation
should have a unique
+ * name; do not reuse the same name for more than one transformation.
+ */
+ default String getName() {
Review Comment:
The doc says `should` not `must`. Having duplicate names or description will
only confuse human readability, not machine readability. For machine
readability, the `uid` counts and we have checks that validate uniqueness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
