davidradl commented on code in PR #27294:
URL: https://github.com/apache/flink/pull/27294#discussion_r2580357585
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/ProviderContext.java:
##########
@@ -41,4 +41,26 @@ public interface ProviderContext {
* in batch mode, or UIDs cannot be guaranteed to be unique.
*/
Optional<String> generateUid(String name);
+
+ /**
+ * Returns the name provided by the framework to label the connector.
+ *
+ * <p>If multiple transformations are present, the implementer decides
which one is the
+ * connector. To distinguish between transformations, each transformation
should have a unique
+ * name; do not reuse the same name for more than one transformation.
+ */
+ default String getName() {
+ return "";
+ }
+
+ /**
+ * Returns the description provided by the framework to label the
connector.
+ *
+ * <p>If multiple transformations are present, the implementer decides
which one is the
+ * connector. To distinguish between transformations, each transformation
should have a unique
+ * description; do not reuse the same description for more than one
transformation.
+ */
+ default String getDescription() {
Review Comment:
I would think the name/identifier would be the unique identifier. Is the
implication here that we reasonably expect names not to be unique so are
relying on descriptions for uniqueness. As with the name, I would expect 1
formal identifier, then human readable attributes like description or
displayName. This allows the description and label to change and the object to
remain the same because the identifier has not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
