davidradl commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/48#discussion_r2676786889
##########
pom.xml:
##########
@@ -717,14 +738,15 @@ under the License.
</property>
</activation>
<properties>
- <target.java.version>1.8</target.java.version>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
@ferenc-csaky I can see that makes sense if we expect downstream repos to
support different min Java versions.
I assume a connector could always release with JDK11 and JDK17 by the
connector supplying an appropriate java level in a release profile
I think we are saying that the parent should not be prescriptive about the
source and target java level in any way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
