ferenc-csaky commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/48#discussion_r2676671775
##########
pom.xml:
##########
@@ -717,14 +738,15 @@ under the License.
</property>
</activation>
<properties>
- <target.java.version>1.8</target.java.version>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
I'm pretty sure we cannot do this here.
Currently, I think every connector still supports JDK11, so if we write
something here as a target version it is JDK11, cause the release artifacts
must be built for the oldest supported version (core Flink has 11 as target
version in the `release` profile).
But as a connector parent, downstream repos might end up supporting
different min Java versions, so I think what's feasible here is to not
overwrite any java version property and just fetch `maven.compiler.target`
inside `requireJavaVersion` as it is now.
That way, one will be able to release with JDK11 and JDK17 adding the given
target profile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
