ferenc-csaky commented on code in PR #48:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/48#discussion_r2677004020
##########
pom.xml:
##########
@@ -717,14 +738,15 @@ under the License.
</property>
</activation>
<properties>
- <target.java.version>1.8</target.java.version>
+ <maven.compiler.source>11</maven.compiler.source>
+ <maven.compiler.target>17</maven.compiler.target>
Review Comment:
Actually, I think for now we should bake Java11 into this release profile,
for both source and target. And when the time comes for the first connector to
drop Java11 support (if it even comes...), then we can release a new parent
that will be pointed to Java17.
TBH I do not like mixing these stuff, it will just bite us in the butt cause
6 months from now nobody will remember what the heck was the intent if we
overcomplicate this, so I'd like to keep it as simple as it can be.
We can either do different release profiles, but regarding this I think we
should ask the community to gather more input. So for this specific PR I'd vote
for locking down Java 11 for both source and target in the release profile,
cause we won't need a Java17 release in the foreseeable future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
