Poorvankbhatia commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3006410415
########## flink-connector-redis-streams/pom.xml: ########## @@ -0,0 +1,63 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: Again, missing license header. Same as External POM. ########## pom.xml: ########## @@ -0,0 +1,142 @@ +<?xml version="1.0" encoding="UTF-8"?> Review Comment: This POM does not inherit from flink-connector-parent, which all externalized Flink connectors use. Please rewrite based on flink-connector-parent:2.0.0 as the parent — it provides RAT, checkstyle, spotless, etc out of the box, and refer to [Kafka Connector's pom.xml ](https://github.com/apache/flink-connector-kafka/blob/main/pom.xml)as the structural template. This will give u everything: ``` <parent> <groupId>org.apache.flink</groupId> <artifactId>flink-connector-parent</artifactId> <version>2.0.0</version> </parent> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
