Poorvankbhatia commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3006410695
########## pom.xml: ########## @@ -0,0 +1,142 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; Review Comment: Missing ASF license header. ########## pom.xml: ########## @@ -0,0 +1,142 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.flink</groupId> Review Comment: Missing ``` <parent> <artifactId>flink-connector-parent</artifactId> <version>2.0.0</version></parent> ``` block before this. Without it, you lose 8+ standard build plugins. Also, why is the version 3.0.0-SNAPSHOT? This is a new connector, should be 1.0-SNAPSHOT. ########## pom.xml: ########## @@ -0,0 +1,142 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-redis-streams-parent</artifactId> + <version>3.0.0-SNAPSHOT</version> + <packaging>pom</packaging> + + <name>Flink : Connectors : Redis Streams : Parent</name> Review Comment: Again Missing `<inceptionYear> & <scm> ` section. ########## pom.xml: ########## @@ -0,0 +1,142 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-redis-streams-parent</artifactId> + <version>3.0.0-SNAPSHOT</version> + <packaging>pom</packaging> + + <name>Flink : Connectors : Redis Streams : Parent</name> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.source>17</maven.compiler.source> + <maven.compiler.target>17</maven.compiler.target> Review Comment: Both these lines are redundant — these are set again in the maven-compiler-plugin config below. With **flink- connector-parent**, neither is needed, i.e., **flink- connector-parent** the compiler plugin is already configured in the parent POM. You don't write either. The parent handles it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
