raminqaf commented on code in PR #27886: URL: https://github.com/apache/flink/pull/27886#discussion_r3115321665
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TraitCondition.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.inference; + +import org.apache.flink.annotation.PublicEvolving; + +import java.io.Serializable; + +/** + * A condition that determines whether a conditional trait on a {@link StaticArgument} should be + * active for a given call. + * + * <p>Conditions are evaluated at planning time using the {@link TraitContext} which provides access + * to the SQL call's properties (PARTITION BY presence, scalar argument values, etc.). + * + * <p>Use the static factory methods for common conditions: + * + * <pre>{@code + * import static org.apache.flink.table.types.inference.TraitCondition.*; + * + * StaticArgument.table("input", Row.class, false, EnumSet.of(TABLE, SUPPORT_UPDATES)) + * .addTraitWhen(hasPartitionBy(), SET_SEMANTIC_TABLE) + * .addTraitWhen(not(hasPartitionBy()), ROW_SEMANTIC_TABLE) + * .addTraitWhen(argIsTrue("produces_full_deletes"), REQUIRE_UPDATE_BEFORE); + * }</pre> + */ +@PublicEvolving +@FunctionalInterface +public interface TraitCondition extends Serializable { Review Comment: How about we extend Java's `Predicate`? ```suggestion public interface TraitCondition extends Serializable, Predicate<TraitContext> { ``` ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StaticArgument.java: ########## @@ -196,6 +240,68 @@ public boolean is(StaticArgumentTrait trait) { return traits.contains(trait); } + /** + * Context-aware trait check. Evaluates conditional trait rules against the given context to + * determine the effective traits. + */ + public boolean is(StaticArgumentTrait trait, TraitContext ctx) { + return resolveTraits(ctx).contains(trait); + } + + /** + * Returns a new {@link StaticArgument} with an additional conditional trait rule. The trait is + * added to the effective trait set when the condition evaluates to {@code true} at planning + * time. + * + * <p>Example: + * + * <pre>{@code + * StaticArgument.table("input", Row.class, false, EnumSet.of(TABLE, SUPPORT_UPDATES)) + * .addTraitWhen(hasPartitionBy(), SET_SEMANTIC_TABLE) + * .addTraitWhen(not(hasPartitionBy()), ROW_SEMANTIC_TABLE); + * }</pre> + */ + public StaticArgument addTraitWhen( + final TraitCondition condition, final StaticArgumentTrait trait) { + final List<ConditionalTrait> newList = new ArrayList<>(this.conditionalTraits); Review Comment: Any reason we copy the list everytime we add new elements to it? ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StaticArgument.java: ########## @@ -57,18 +61,58 @@ public class StaticArgument { private final @Nullable Class<?> conversionClass; private final boolean isOptional; private final EnumSet<StaticArgumentTrait> traits; + private final List<ConditionalTrait> conditionalTraits; + + /** A trait that is conditionally added based on a {@link TraitCondition}. */ + private static final class ConditionalTrait implements Serializable { + private final TraitCondition condition; + private final StaticArgumentTrait trait; + + ConditionalTrait(final TraitCondition condition, final StaticArgumentTrait trait) { + this.condition = condition; + this.trait = trait; + } + + @Override + public boolean equals(final Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + final ConditionalTrait that = (ConditionalTrait) o; + return Objects.equals(condition, that.condition) && trait == that.trait; + } + + @Override + public int hashCode() { + return Objects.hash(condition, trait); + } + } private StaticArgument( String name, @Nullable DataType dataType, @Nullable Class<?> conversionClass, boolean isOptional, EnumSet<StaticArgumentTrait> traits) { + this(name, dataType, conversionClass, isOptional, traits, List.of()); + } + + private StaticArgument( + String name, + @Nullable DataType dataType, + @Nullable Class<?> conversionClass, + boolean isOptional, + EnumSet<StaticArgumentTrait> traits, + List<ConditionalTrait> conditionalTraits) { this.name = Preconditions.checkNotNull(name, "Name must not be null."); this.dataType = dataType; this.conversionClass = conversionClass; this.isOptional = isOptional; this.traits = Preconditions.checkNotNull(traits, "Traits must not be null."); + this.conditionalTraits = Collections.unmodifiableList(conditionalTraits); Review Comment: ```suggestion this.conditionalTraits = conditionalTraits; ``` ########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StaticArgument.java: ########## @@ -57,18 +61,58 @@ public class StaticArgument { private final @Nullable Class<?> conversionClass; private final boolean isOptional; private final EnumSet<StaticArgumentTrait> traits; + private final List<ConditionalTrait> conditionalTraits; + + /** A trait that is conditionally added based on a {@link TraitCondition}. */ + private static final class ConditionalTrait implements Serializable { + private final TraitCondition condition; + private final StaticArgumentTrait trait; + + ConditionalTrait(final TraitCondition condition, final StaticArgumentTrait trait) { + this.condition = condition; + this.trait = trait; + } + + @Override + public boolean equals(final Object o) { + if (this == o) { + return true; + } + if (o == null || getClass() != o.getClass()) { + return false; + } + final ConditionalTrait that = (ConditionalTrait) o; + return Objects.equals(condition, that.condition) && trait == that.trait; + } + + @Override + public int hashCode() { + return Objects.hash(condition, trait); + } + } private StaticArgument( String name, @Nullable DataType dataType, @Nullable Class<?> conversionClass, boolean isOptional, EnumSet<StaticArgumentTrait> traits) { + this(name, dataType, conversionClass, isOptional, traits, List.of()); + } + + private StaticArgument( + String name, + @Nullable DataType dataType, + @Nullable Class<?> conversionClass, + boolean isOptional, + EnumSet<StaticArgumentTrait> traits, + List<ConditionalTrait> conditionalTraits) { Review Comment: Not sure if a list is the most suitable data structure for the traits here. Maybe representing as a HashMap would make more sense. With a list we could still allow the user to define two conditional traits with the same StaticArgument. [`StaticArgumentTrait.SET_SEMANTIC_TABLE, hasPartitionBy`, `StaticArgumentTrait.SET_SEMANTIC_TABLE, hasSomeCondition`] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
