gustavodemorais commented on code in PR #27886:
URL: https://github.com/apache/flink/pull/27886#discussion_r3116886182
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalProcessTableFunctionRule.java:
##########
@@ -127,9 +138,17 @@ private static RelNode applyDistributionOnInput(
}
private static FlinkRelDistribution deriveDistribution(
- RexTableArgCall tableOperand, TableCharacteristic
tableCharacteristic) {
- if (tableCharacteristic.semantics == Semantics.SET) {
- final int[] partitionKeys = tableOperand.getPartitionKeys();
+ RexTableArgCall tableOperand,
+ TableCharacteristic tableCharacteristic,
+ StaticArgument staticArg) {
+ final int[] partitionKeys = tableOperand.getPartitionKeys();
+ final boolean hasPartitionBy = partitionKeys.length > 0;
+ final boolean reportedAsSet = tableCharacteristic.semantics ==
Semantics.SET;
+ final boolean setIsConditional =
+
staticArg.hasConditionalTrait(StaticArgumentTrait.SET_SEMANTIC_TABLE);
Review Comment:
I've done this but I'm not sure I like the new version better:
Now: We don't have TraitContext here. I can build a simple TraitContext
based on the partition as I did. Not considerably less fragile
Before: Only check the partition by
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
