gustavodemorais commented on code in PR #27886:
URL: https://github.com/apache/flink/pull/27886#discussion_r3116997114
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/StaticArgument.java:
##########
@@ -57,18 +61,58 @@ public class StaticArgument {
private final @Nullable Class<?> conversionClass;
private final boolean isOptional;
private final EnumSet<StaticArgumentTrait> traits;
+ private final List<ConditionalTrait> conditionalTraits;
+
+ /** A trait that is conditionally added based on a {@link TraitCondition}.
*/
+ private static final class ConditionalTrait implements Serializable {
+ private final TraitCondition condition;
+ private final StaticArgumentTrait trait;
+
+ ConditionalTrait(final TraitCondition condition, final
StaticArgumentTrait trait) {
+ this.condition = condition;
+ this.trait = trait;
+ }
+
+ @Override
+ public boolean equals(final Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ final ConditionalTrait that = (ConditionalTrait) o;
+ return Objects.equals(condition, that.condition) && trait ==
that.trait;
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(condition, trait);
+ }
+ }
private StaticArgument(
String name,
@Nullable DataType dataType,
@Nullable Class<?> conversionClass,
boolean isOptional,
EnumSet<StaticArgumentTrait> traits) {
+ this(name, dataType, conversionClass, isOptional, traits, List.of());
+ }
+
+ private StaticArgument(
+ String name,
+ @Nullable DataType dataType,
+ @Nullable Class<?> conversionClass,
+ boolean isOptional,
+ EnumSet<StaticArgumentTrait> traits,
+ List<ConditionalTrait> conditionalTraits) {
Review Comment:
I've given this some though and decided we could go with OR semantics for
multiple conditional traits for the same trait. This makes it possible that the
user writes multiple simple condition traits and thus a list makes sense. the
trait is activated if any of its conditions is met. I've documented the behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
