gustavodemorais commented on PR #27886: URL: https://github.com/apache/flink/pull/27886#issuecomment-4288250578
One note @twalthr, I've had the feeling multiple times that "isPtfUpsert" wasn't the best name for the function so I did a small refactoring and renamed it to "requiresUpdateBefore" adjusting the logic in the appropriate places. That helps with understanding that it's related to the input of the ptf and says exactly what we're checking. I think the code is easier to read now. Take a look and let me know what you think https://github.com/apache/flink/pull/27886/commits/c0e2242e25185656c11c05e67bd061d29dba0d4a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
