gguptp commented on code in PR #36:
URL:
https://github.com/apache/flink-connector-hive/pull/36#discussion_r3163289086
##########
flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java:
##########
@@ -463,9 +462,8 @@ public static Table alterTableViaCatalogBaseTable(
ObjectPath tablePath,
ResolvedCatalogBaseTable baseTable,
Table oldHiveTable,
- HiveConf hiveConf,
- boolean managedTable) {
- Table newHiveTable = instantiateHiveTable(tablePath, baseTable,
hiveConf, managedTable);
+ HiveConf hiveConf) {
Review Comment:
given we're removing managedTable API which no longer exists in flink 2,
will we have any issue for customers migrating from flink 1 connector to flink
2 connector? will there be hive tables which have connector=flink-managed
property
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
