jlalwani-amazon commented on code in PR #36:
URL:
https://github.com/apache/flink-connector-hive/pull/36#discussion_r3163529343
##########
flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java:
##########
@@ -463,9 +462,8 @@ public static Table alterTableViaCatalogBaseTable(
ObjectPath tablePath,
ResolvedCatalogBaseTable baseTable,
Table oldHiveTable,
- HiveConf hiveConf,
- boolean managedTable) {
- Table newHiveTable = instantiateHiveTable(tablePath, baseTable,
hiveConf, managedTable);
+ HiveConf hiveConf) {
Review Comment:
Thanks for the review, @gguptp
Good question! The ManagedTable API was removed from Flink core in 2.0
(FLINK-36539), so this isn't specific to the connector. it's a Flink-wide
change.
For existing tables with connector=flink-managed in the Hive metastore:
the underlying data (files in HDFS/S3) is unaffected. Those tables remain
readable as regular Hive tables. The connector property becomes inert. Flink
2.0 simply won't recognize it as a managed table and will treat it as a
standard Hive table instead.
The only behavioral difference is that DROP TABLE on a previously managed
table will no longer trigger Flink-side data cleanup. Users would need to clean
up the data files manually or rely on Hive's native managed table behavior.
Since the ManagedTable feature was experimental and the removal was a
deliberate Flink core decision, I think this is expected migration behavior
rather than something the connector should try to paper over. We should update
the FLink 2.0 migration guide to call out the change in behavior with
managed-table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
