jlalwani-amazon commented on code in PR #36:
URL:
https://github.com/apache/flink-connector-hive/pull/36#discussion_r3164125531
##########
flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java:
##########
@@ -463,9 +462,8 @@ public static Table alterTableViaCatalogBaseTable(
ObjectPath tablePath,
ResolvedCatalogBaseTable baseTable,
Table oldHiveTable,
- HiveConf hiveConf,
- boolean managedTable) {
- Table newHiveTable = instantiateHiveTable(tablePath, baseTable,
hiveConf, managedTable);
+ HiveConf hiveConf) {
Review Comment:
On the subject of migration, one thing that I want to highlight is that
Flink 2 is incompatible with Hive 3. I have highlighted this in the description
above and created a discussion thread on the mailing list. Reiterating it here
for emphasis.
Flink 2 is on JDK17. Hive 3 doesn't work on JDK 17. So, essentially,
migrating to Flink 2.0 will leave users high and dry unless we add support for
Hive 4. I have Hive 4 support in [this
PR](https://github.com/apache/flink-connector-hive/pull/37)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
