wenjin272 commented on code in PR #641:
URL: https://github.com/apache/flink-agents/pull/641#discussion_r3165903700
##########
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java:
##########
@@ -191,7 +194,7 @@ public class ActionExecutionOperator<IN, OUT> extends
AbstractStreamOperator<OUT
private transient ListState<Object> currentProcessingKeysOpState;
private final transient EventLogger eventLogger;
- private final transient List<EventListener> eventListeners;
Review Comment:
I think we can keep the `final` to maintain alignment with eventLogger. In
`initEventListeners`, We can use `addAll` instead of assigning the entire
collection at once.
##########
api/src/main/java/org/apache/flink/agents/api/listener/EventListener.java:
##########
@@ -31,6 +31,9 @@
* <p>Event listeners are executed synchronously after the main event
processing is complete but
* before the next event is processed. Implementations should be lightweight
and avoid blocking
* operations to prevent impacting agent performance.
Review Comment:
It appears that the EventListener is actually triggered before the Event is
processed in `ActionExecutionOperator`, which is inconsistent with the
documentation here. We may need to update either the doc or the invocation
location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
