wenjin272 commented on code in PR #641:
URL: https://github.com/apache/flink-agents/pull/641#discussion_r3193814116
##########
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java:
##########
@@ -411,6 +442,8 @@ private void processEvent(Object key, Event event) throws
Exception {
// If the event is an InputEvent, we submit a new mail to try
processing the actions.
mailboxExecutor.submit(() -> tryProcessActionTaskForKey(key),
"process action task");
}
+
+ notifyEventProcessed(event);
Review Comment:
Hi, @twosom. I carefully reviewed the logic of `processEvent`. In this
function, only an `ActionTask` is created and submitted. It's actual execution
occurs in subsequent mailbox iterations. Therefore, merely moving
`notifyEventProcessed` to the end of the function still remains inconsistent
with the documentation of `EventListener`. After considering all factors, I
think it's simpler to place it at the beginning and update the `EventListener`
documentation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
