twosom commented on code in PR #641:
URL: https://github.com/apache/flink-agents/pull/641#discussion_r3208603627
##########
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java:
##########
@@ -411,6 +442,8 @@ private void processEvent(Object key, Event event) throws
Exception {
// If the event is an InputEvent, we submit a new mail to try
processing the actions.
mailboxExecutor.submit(() -> tryProcessActionTaskForKey(key),
"process action task");
}
+
+ notifyEventProcessed(event);
Review Comment:
Thanks for the catch, @wenjin272
I missed the point that the actual execution happens in subsequent mailbox
iterations. I agree that calling it at the beginning and updating the Javadoc
is the best way to avoid inconsistency. I'll update the code and the
documentation accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
