Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178695732
########## pom.xml: ########## @@ -0,0 +1,142 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> + + <groupId>org.apache.flink</groupId> + <artifactId>flink-connector-redis-streams-parent</artifactId> + <version>3.0.0-SNAPSHOT</version> + <packaging>pom</packaging> + + <name>Flink : Connectors : Redis Streams : Parent</name> + + <properties> + <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <maven.compiler.source>17</maven.compiler.source> + <maven.compiler.target>17</maven.compiler.target> + <flink.version>2.2.0</flink.version> Review Comment: @Poorvankbhatia Bumping JUnit to 5.13.x breaks the build: JUnit Platform 1.13.0 (bundled with 5.13.x) introduced OutputDirectoryProvider, which maven-surefire-plugin:3.2.5. The version is locked in flink-connector-parent:2.0.0 does not support. Upgrading surefire requires changing the parent POM, which is outside the scope of this connector PR. Keeping 5.10.2 (the version currently in the parent POM's ecosystem). Happy to track a follow-up to bump both surefire and JUnit together once the parent POM is updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
