Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178643651
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/split/RedisStreamsSourceSplitSerializer.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.split; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.core.io.SimpleVersionedSerializer; +import org.apache.flink.core.memory.DataInputDeserializer; +import org.apache.flink.core.memory.DataOutputSerializer; + +import java.io.IOException; + +/** + * Binary serializer for {@link RedisStreamsSourceSplit}. v1 contained {@code lastReadEntryId}; + * v2 splits it into {@code startingEntryId} + {@code stoppingEntryId} and migrates v1 payloads. + */ +@Internal +public final class RedisStreamsSourceSplitSerializer Review Comment: Serializer coverage already lives in RedisStreamsSourceSplitTest.java: - roundTripV1 — parametrised round-trip over all null/non-null combinations, including keys with special characters. - unknownVersionRejected — verifies that version ≠ 1 throws IOException with "Unsupported". Creating a second test class for the same serializer would duplicate setup and split related test knowledge across files. The existing class is named RedisStreamsSourceSplitTest and tests both the split model and its serializer together, which is a common pattern in the Flink connector ecosystem. Happy to split into a separate file if this is a firm convention requirement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
