Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178645462
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/enumerator/RedisStreamsSourceEnumeratorState.java: ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.enumerator; + +import org.apache.flink.annotation.Internal; + +import java.util.Collections; +import java.util.Map; +import java.util.Objects; +import java.util.Set; + +/** Checkpointed enumerator state: unassigned stream keys + frozen bounded-mode stopping IDs. */ +@Internal +public class RedisStreamsSourceEnumeratorState { + + private final Set<String> pendingSplits; + private final Map<String, String> stoppingEntryIds; Review Comment: RedisStreamsSourceEnumeratorState stores Set<String> (stream keys), not Set<RedisStreamsSourceSplit>, for good reasons: 1. The enumerator has no split position at checkpoint time. Pending splits haven't been assigned yet; their startingEntryId and stoppingEntryId are only resolved at assignment time by querying Redis. Storing a RedisStreamsSourceSplit would require inventing placeholder field values. 2. Size. A stream key is a plain string. Storing the full split object just to hold the same string adds no information and couples the state format to split internals. 3. Separation of concerns. The enumerator knows about stream keys; the reader knows about splits. The enumerator reconstructs splits at assignment time, which is the right seam. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
