gustavodemorais commented on code in PR #28164:
URL: https://github.com/apache/flink/pull/28164#discussion_r3265110228
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -614,7 +614,32 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
/** Java-friendly overload that accepts a list of [[ExplainDetail]]s. */
def verifyRelPlan(query: String, extraDetails:
java.util.List[ExplainDetail]): Unit = {
- verifyRelPlan(query, extraDetails.asScala.toSeq: _*)
+ verifyRelPlan(query, extraDetails.asScala: _*)
+ }
+
+ /**
+ * Verify the AST and the optimized rel plan for the given SELECT query. The
rendered optimized
+ * rel plan includes the `upsertKeys=[...]` term for rel nodes that derive
upsert keys.
+ */
+ def verifyRelPlanWithUpsertKey(query: String, extraDetails: ExplainDetail*):
Unit = {
Review Comment:
This does not seem to fit the style of the utilities we have here. We don
have unique verifyRelPlan for each param we can configure. Take a look at how
withDuplicateChanges and withQueryBlockAlias were implemented
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
