gustavodemorais commented on code in PR #28164:
URL: https://github.com/apache/flink/pull/28164#discussion_r3267449713
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -1057,7 +1073,8 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
withRowType,
expectedPlans,
() => assertEqualsOrExpand("sql", query),
- withQueryBlockAlias)
+ withQueryBlockAlias,
+ withUpsertKey = withUpsertKey)
Review Comment:
let's either used named args or not in one call
```suggestion
withQueryBlockAlias,
withUpsertKey)
```
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -614,7 +614,7 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
/** Java-friendly overload that accepts a list of [[ExplainDetail]]s. */
def verifyRelPlan(query: String, extraDetails:
java.util.List[ExplainDetail]): Unit = {
- verifyRelPlan(query, extraDetails.asScala.toSeq: _*)
+ verifyRelPlan(query, extraDetails.asScala: _*)
Review Comment:
Did you mean to change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
