raminqaf commented on code in PR #28164:
URL: https://github.com/apache/flink/pull/28164#discussion_r3271568200
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala:
##########
@@ -1057,7 +1073,8 @@ abstract class TableTestUtilBase(test: TableTestBase,
isStreamingMode: Boolean)
withRowType,
expectedPlans,
() => assertEqualsOrExpand("sql", query),
- withQueryBlockAlias)
+ withQueryBlockAlias,
+ withUpsertKey = withUpsertKey)
Review Comment:
@gustavodemorais assertPlanEquals param order is (..., withQueryBlockAlias,
withDuplicateChanges, withUpsertKey). Passing withUpsertKey positionally at
slot 7 bound it to withDuplicateChanges.
This produces a new plan and breaks the test. I will revert to the named arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
