weiqingy commented on code in PR #835:
URL: https://github.com/apache/flink-agents/pull/835#discussion_r3408396219
##########
python/flink_agents/plan/agent_plan.py:
##########
@@ -280,6 +294,8 @@ def _get_actions(agent: Agent) -> List[Action]:
if marker is None:
continue
inner, listen_events, target = marker
+ if target is None:
+ _warn_if_action_returns_value(name, inner)
Review Comment:
Sounds good — keeping it scoped to #834 and handling `add_action` in a
separate follow-up is the right call; no need to widen this PR. A focused
follow-up reads cleaner than folding it in here.
I also traced the `target=`-style decorated actions (the `target is not
None` branch) to be sure it isn't a second silent-discard spot: there the
decorated method is just a stub and the real executed function is the
descriptor's `target`, so skipping the stub's annotation is correct. That
leaves `add_action` as the only genuinely uncovered path, which your follow-up
covers. Current change LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
