weiqingy commented on PR #835: URL: https://github.com/apache/flink-agents/pull/835#issuecomment-4699392121
> Thanks for review @weiqingy! Yes I scoped this to decorated @ action methods to match issue #834, so leaving out add_action was intentional. I'd prefer to keep this PR focused and cover the add_action path in a follow up I'll open a separate issue for it. Let me know if you'd rather I fold it into this PR instead. Sounds good. I also traced the target=-style decorated actions (the target is not None branch) to be sure it isn't a second silent-discard spot: there the decorated method is just a stub and the real executed function is the descriptor's target, so skipping the stub's annotation is correct. That leaves add_action as the only genuinely uncovered path, which your follow-up covers. Current change LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
