pltbkd commented on PR #1206: URL: https://github.com/apache/flink-agents/pull/1206#issuecomment-6121419865
Thanks for the PR. I read this PR as two parts: introducing SubagentMetadataProvider for an Agent to implement so it can provide the description and schema used for model-driven invocation, and extending ReActAgent with it. My concern is about SubagentMetadataProvider. IMO, a subagent can be a component shared among agents. Its functional description may be the same, but when to use it can differ from one agent to another — a physical-machine diagnoser may also serve several distributed systems, but each of them needs different trigger symptoms, e.g. a specific metric going abnormal. Besides, I also think we'd better support registering an Agent as a subagent without requiring the Agent to be modified, or to follow some rules, for this kind of usage. From both points of view, I think we should not introduce an interface that subagents are required to implement, but instead provide the metadata at registration. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
