eemario commented on code in PR #1206:
URL: https://github.com/apache/flink-agents/pull/1206#discussion_r4256090080


##########
plan/src/main/java/org/apache/flink/agents/plan/serializer/ResourceProviderJsonSerializer.java:
##########
@@ -128,6 +128,12 @@ private void serializeInternalSubagentProvider(
         gen.writeStringField("name", provider.getName());
         gen.writeStringField("type", provider.getType().getValue());
         gen.writeStringField("scope", provider.getScope());
+        if (provider.getDescription() != null) {
+            gen.writeStringField("description", provider.getDescription());
+        }
+        if (provider.getInputSchema() != null) {
+            gen.writeStringField("inputSchema", provider.getInputSchema());

Review Comment:
   Fixed. The cross-language key is now consistently `input_schema`, and both 
`description` and `input_schema` are preserved when converting an internal 
sub-agent provider in either direction. I also added Java/Python round-trip and 
cross-language regression coverage.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to