eemario commented on code in PR #1206:
URL: https://github.com/apache/flink-agents/pull/1206#discussion_r4256087421


##########
python/flink_agents/api/agents/react_agent.py:
##########
@@ -105,6 +112,8 @@ def __init__(
         chat_model: ResourceDescriptor,
         prompt: Prompt | None = None,
         output_schema: type[BaseModel] | RowTypeInfo | None = None,
+        subagent_description: str | None = None,
+        subagent_input_schema: str | None = None,

Review Comment:
   Thanks for catching this. I moved the caller-facing metadata to the 
sub-agent registration, so a bare Agent no longer carries a default schema for 
model-driven delegation. The registration API and ReActAgent documentation now 
state that the schema field names must match the child prompt placeholders, 
with matching examples for both Java and Python. The framework does not attempt 
validation because both prompts and JSON Schemas can express shapes that cannot 
be matched reliably at construction time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to