eemario commented on code in PR #1206:
URL: https://github.com/apache/flink-agents/pull/1206#discussion_r4265814881


##########
plan/src/main/java/org/apache/flink/agents/plan/serializer/ResourceProviderJsonSerializer.java:
##########
@@ -128,6 +128,12 @@ private void serializeInternalSubagentProvider(
         gen.writeStringField("name", provider.getName());
         gen.writeStringField("type", provider.getType().getValue());
         gen.writeStringField("scope", provider.getScope());
+        if (provider.getDescription() != null) {
+            gen.writeStringField("description", provider.getDescription());
+        }
+        if (provider.getInputSchema() != null) {
+            gen.writeStringField("inputSchema", provider.getInputSchema());

Review Comment:
   Update: after rebasing onto #1242, the `input_schema` key and the 
cross-language metadata now come from #1242, so this PR no longer changes the 
serializer.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to