Copilot commented on code in PR #28995:
URL: https://github.com/apache/flink/pull/28995#discussion_r4280520448
##########
flink-kubernetes/pom.xml:
##########
@@ -75,10 +80,12 @@ under the License.
</exclusions>
</dependency>
- <!-- Since 7.0.0, Fabric8 uses Vert.x as its HTTP client, but
we want to use OkHttp to keep the same dependencies as used before this
version. -->
+ <!-- Since 7.0.0, Fabric8 uses Vert.x as its default HTTP
client. We use the built-in java.net.http (JDK)
+ client instead (see fabric8.httpclient.impl above),
which keeps OkHttp/okio/Kotlin off the classpath and
+ avoids pulling in Vert.x/Netty. -->
<dependency>
<groupId>io.fabric8</groupId>
- <artifactId>kubernetes-httpclient-okhttp</artifactId>
+
<artifactId>kubernetes-httpclient-${fabric8.httpclient.impl}</artifactId>
Review Comment:
Switching to the JDK adapter breaks HTTPS Kubernetes API access through
authenticated HTTP proxies, such as `HTTPS_PROXY=http://user:pass@proxy:port`.
Fabric8 7.8.0's JDK adapter adds `Proxy-Authorization` to application requests
but does not configure a JDK `Authenticator`; the JDK-generated CONNECT request
omits the credentials and receives HTTP 407. This blocks deployment and
Kubernetes HA access for affected configurations that worked with the OkHttp
adapter. Preserve CONNECT proxy authentication and add a regression test. If
this compatibility break is intentional, explicitly reject and document
authenticated proxies as unsupported rather than documenting only the SOCKS
limitation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
