snuyanzin commented on code in PR #28995:
URL: https://github.com/apache/flink/pull/28995#discussion_r4303778992


##########
flink-dist/pom.xml:
##########
@@ -593,6 +593,31 @@ under the License.
                                                        <skip>true</skip>
                                                </configuration>
                                        </execution>
+                                       <execution>
+                                               <!-- Keep OkHttp/okio off the 
core Flink distribution classpath. Metrics reporters that
+                                                        bundle OkHttp declare 
it as an optional (non-transitive) dependency and ship it shaded
+                                                        inside their plugin 
jar. The intellij profile (flink.markBundledAsOptional=false) makes it
+                                                        transitive, so it can 
show up here in provided scope, which is never bundled. -->

Review Comment:
   can you make your ai more succinct? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to