snuyanzin commented on code in PR #28995:
URL: https://github.com/apache/flink/pull/28995#discussion_r4303782636
##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/utils/KubernetesUtilsTest.java:
##########
@@ -228,4 +231,52 @@ private void testCheckAndUpdatePortConfigOption(
assertThat(cfg.get(HighAvailabilityOptions.HA_JOB_MANAGER_PORT_RANGE))
.isEqualTo(expectedPort);
}
+
+ @ParameterizedTest
+ @ValueSource(
+ strings = {
+ "11.0.18",
+ "11.0.18+10",
+ "11.0.18.1+1",
+ "11.0.17+8-LTS",
+ "11.0.11+9",
+ "12.0.2",
+ "15.0.1"
+ })
+ void testCheckJdkHttpClientSupportRejectsJdksWithoutWebSocketFix(String
version) {
+ assertThatThrownBy(
+ () ->
+ KubernetesUtils.checkJdkHttpClientSupport(
+ Runtime.Version.parse(version)))
+ .isInstanceOf(IllegalStateException.class)
+ .hasMessageContaining(version)
+ .hasMessageContaining("11.0.19");
Review Comment:
better to check for the whole message rather than some containing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
