Timm0 opened a new pull request, #29843:
URL: https://github.com/apache/flink/pull/29843
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Azure Pipelines CI to do that following [this
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
When a materialized table statement starts a continuous refresh job but the
catalog then fails to record it, the job keeps running unrecorded. On `CREATE`
the table is dropped and the job is orphaned. On `RESUME`, convert-to-MT and
the `ALTER` restart the table survives, so a retry, or the `ALTER` rollback,
starts a second job writing to the same sink. This change cancels the
unrecorded job on all four paths, keeps the original error when compensation
fails, and names the savepoint when `SUSPEND` cannot record it. This is shared
new behavior for the SQL Gateway and Table API.
## Brief change log
- `executeContinuousRefreshJob` cancels the job when recording it fails.
CREATE, RESUME, convert, the ALTER restart and the ALTER rollback's restart all
go through it. A failed submit still only throws.
- ALTER: when the new job cannot be cancelled, the table is rolled back and
left SUSPENDED, and the old job is not restarted, which avoids two writers.
- When the compensating drop, rollback or suspend fails, the original
failure is kept as a suppressed exception. CREATE reports a table left in
INITIALIZING.
- When the catalog write after stop-with-savepoint fails, SUSPEND (and any
ALTER that stops the job) names the savepoint and the
`execution.state-recovery.path` hint.
- New `FailingCatalog`-based tests in `DefaultMaterializedTableExecutorTest`
cover each path, including the cases where the cancel fails.
- `statements.md` (en, zh) documents the cancel behaviour.
## Verifying this change
This change added tests and can be verified as follows:
- Added `DefaultMaterializedTableExecutorTest` cases that use a
`FailingCatalog` to fail a selected `alterTable` call:
- CREATE, RESUME and convert cancel a refresh job they could not record
- CREATE reports a job it could neither record nor cancel
- ALTER cancels the new job before restarting the old one from its
savepoint
- ALTER rolls back to SUSPENDED and does not restart the old job when
the new one cannot be cancelled
- SUSPEND names the savepoint and the `execution.state-recovery.path`
hint when the catalog write after the stop fails
- The existing `MaterializedTableTableApiITCase` and
`MaterializedTableStatementITCase` still pass.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? docs
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` and replace the placeholder in the
"Generated-by"
line with the tool name and version. Otherwise remove the "Generated-by"
line.
See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Code Opus 5.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
