Timm0 commented on code in PR #29843:
URL: https://github.com/apache/flink/pull/29843#discussion_r4537442171
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/materializedtable/DefaultMaterializedTableExecutor.java:
##########
@@ -262,12 +280,17 @@ private void
convertTableToMaterializedTableInContinuousMode(
Map.of(),
Optional.empty());
} catch (Exception e) {
- suspendMaterializedTable(materializedTableIdentifier,
catalogMaterializedTable);
+ try {
+ suspendMaterializedTable(materializedTableIdentifier,
catalogMaterializedTable);
+ } catch (RuntimeException suspendFailure) {
+ suspendFailure.addSuppressed(e);
+ throw suspendFailure;
+ }
throw new TableException(
String.format(
- "Failed to start the continuous refresh job when
converting table %s to a materialized table. "
+ "Failed to start the continuous refresh job when
converting table '%s' to a materialized table. "
+ "The table was converted and left in
SUSPENDED status; resume it once the issue is resolved.",
- materializedTableIdentifier),
+ materializedTableIdentifier.asSummaryString()),
e);
Review Comment:
This is already tracked in
[FLINK-41350](https://issues.apache.org/jira/browse/FLINK-41350). @raminqaf
handed it over to me this morning, so I'll do it as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
