Timm0 commented on code in PR #29843:
URL: https://github.com/apache/flink/pull/29843#discussion_r4537420805
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/materializedtable/DefaultMaterializedTableExecutor.java:
##########
@@ -507,8 +548,8 @@ private void resumeContinuousRefreshJob(
} catch (Exception e) {
throw new TableException(
String.format(
- "Failed to resume the continuous refresh job for
materialized table %s.",
- tableIdentifier),
+ "Failed to resume the continuous refresh job for
materialized table '%s'.",
+ tableIdentifier.asSummaryString()),
e);
Review Comment:
Done
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/materializedtable/DefaultMaterializedTableExecutor.java:
##########
@@ -560,6 +601,25 @@ private void executeContinuousRefreshJob(
ObjectIdentifier materializedTableIdentifier,
Map<String, String> dynamicOptions,
Optional<String> restorePath) {
+ final ContinuousRefreshHandler refreshHandler =
+ submitContinuousRefreshJob(
+ catalogMaterializedTable,
+ materializedTableIdentifier,
+ dynamicOptions,
+ restorePath);
+ try {
+ recordContinuousRefreshJob(
+ materializedTableIdentifier, catalogMaterializedTable,
refreshHandler);
+ } catch (Exception e) {
+ throw cancelUnrecordedRefreshJob(materializedTableIdentifier,
refreshHandler, e);
+ }
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
