Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102475557
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarFunctionCallGen.scala
---
@@ -48,10 +48,16 @@ class ScalarFunctionCallGen(
.getOrElse(throw new CodeGenException("No matching signature
found."))
val resultClass = getResultTypeClass(scalarFunction, matchingSignature)
+ // zip for variable signatures
+ var paramToOperands = matchingSignature.zip(operands)
+ var i = paramToOperands.length
+ while (i < operands.length) {
+ paramToOperands = paramToOperands :+ (matchingSignature.head,
operands(i))
--- End diff --
Why take head of `matchingSignature`? Isn't the vararg the last one of
signatures ?
And I think we should take the component type of the vararg array type to
be the operand class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
