Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3389#discussion_r102472512
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
---
@@ -140,6 +147,25 @@ object UserDefinedFunctionUtils {
s"one method named 'eval' which is public, not abstract and " +
s"(in case of table functions) not static.")
} else {
+ var trailingSeq = false
+ var trailingArray = false
+ methods.foreach(method => {
+ val signatures = method.getParameterTypes
+ if (signatures.nonEmpty) {
+ val trailingArg = signatures(signatures.length - 1)
+ if (trailingArg.getName.equals("scala.collection.Seq")) {
+ trailingSeq = true
+ } else if (trailingArg.isArray) {
+ trailingArray = true
+ }
+ }
+ })
+ if (trailingSeq && !trailingArray) {
--- End diff --
The `eval` method can be overloaded. Such as :
```scala
def eval(args: Array[Int]): Int = {}
def eval(args: Int*): Int = {}
```
In this case, the methods can satisfy the condition, but the exception
should be thrown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
