Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3389#discussion_r102464697
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala
 ---
    @@ -87,10 +87,16 @@ object UserDefinedFunctionUtils {
           // go over all signatures and find one matching actual signature
           .find { curSig =>
           // match parameters of signature to actual parameters
    -      actualSignature.length == curSig.length &&
    +      (actualSignature.length == curSig.length &&
             curSig.zipWithIndex.forall { case (clazz, i) =>
               parameterTypeEquals(actualSignature(i), clazz)
    -        }
    +        }) ||
    +        // matching the style which last argument is variable, eg. 
"Type..." "Type*"
    +        (actualSignature.length >= curSig.length &&
    --- End diff --
    
    varargs can be empty, so `actualSignature.length` could be `curSig.length - 
1`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to